Dasemu
40631362b3
Establishes version control for the personal Logseq DB fork before starting the server-client architecture migration and domain features described in docs/agent-guide and the approved implementation plan. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2.3 KiB
2.3 KiB
ADR 0007: Simplify Client DB-Sync for Recycle Semantics
Date: 2026-03-17 Status: Accepted
Context
Client DB sync still contains logic shaped around hard delete. That logic tracks deleted UUIDs, computes deleted subtrees, and runs a second cleanup pass in temp connections to remove nodes after remote apply and local rebase.
The recycle refactor changed deletion semantics. Deleted pages and blocks now remain in the graph with stable UUIDs and are hidden by placement and metadata instead of disappearing.
That means the deleted-context and delete-nodes cleanup flow is no longer the
right model for client sync.
It adds complexity, creates stale test assumptions around db/retractEntity,
and makes the rebase path harder to reason about.
Decision
- Client DB sync will stop treating deletion as entity disappearance.
- The rebase/apply pipeline will operate on ordinary tx streams plus current DB state.
sanitize-tx-datawill no longer accept or derive deleted subtree state.- The extra temp-conn cleanup pass that deletes locally or remotely deleted nodes will be removed.
- Sync sanitization will keep only the behaviors that still matter:
- broken temp-id cleanup
- missing/ref-invalid datom cleanup
- remote/local conflict dropping
- page consistency fixes
- duplicate order fixes
- Recycled targets are treated as invalid active refs by current DB state, rather than through a separate deleted-context channel.
Consequences
- Positive:
- The client sync implementation becomes shorter and easier to reason about.
- Delete and restore semantics stay consistent across local UI, undo/redo, sync, and rebase.
- Tests can assert recycle behavior directly instead of hard-delete side-effects.
- Negative:
- Old tests and assumptions built on
db/retractEntitydelete behavior must be updated. - Minimal stripped-down test DBs need recycle-aware helpers so they do not count recycled nodes as active graph nodes.
- Old tests and assumptions built on
Verification
- DB sync unit coverage:
bb dev:test -v frontend.worker.db-sync-test
- DB sync simulation coverage:
bb dev:test -v frontend.worker.db-sync-sim-test
- Undo/redo compatibility coverage:
bb dev:test -v frontend.undo-redo-test
- Recycle-aware long outliner helper coverage:
bb dev:test -e long -v frontend.modules.outliner.core-test/test-batch-transact